[JENKINS-75003] Zip-based tool installer configuration incorrectly rejects non-HTTP(S) URLs (regression in 2.379) #10065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-75003. Amends #7398 to restore form validation support for non-HTTP(S) URLs.
Testing done
As described in the bug report, created a Maven tool with the "Extract
*.zip
/*.tar.gz
" installer, using a download URL offile:///path/to/apache-maven-3.9.9-bin.tar.gz
and a subdirectory ofapache-maven-3.9.9
. Verified that form validation failed before this PR and passed after this PR. Verified that a Pipeline job succeeded using this tool. Verified that a download URL offil://path/to/invalid
(invalid scheme) still reported a form validation error.Proposed changelog entries
Allow non-HTTP(S) URLs in zip-based tool installer configuration (regression in 2.379).
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist