Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Command Palette UI #10046

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 10, 2024

Small one to refine the interface of the newly introduced Command Palette. These changes are very subtle:

  • Add a slight fade in on opening/closing
  • Corners of items are now rounded correctly
  • Spinner now no longer shows immediately, instead only shows if loading is taking a while (it could appear a little glitchy previously)
  • Fix a bug where Safari won't always show the backdrop-filter, causing text to be unreadable
Screen.Recording.2024-12-10.at.21.40.31.mov

Testing done

  • Command Palette works as expected

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Dec 10, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in chrome looks good

@timja timja requested a review from a team December 10, 2024 22:17
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good too

@timja
Copy link
Member

timja commented Dec 11, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 11, 2024
@timja timja merged commit 65bbc5d into jenkinsci:master Dec 12, 2024
16 checks passed
@janfaracik janfaracik deleted the refine-command-palette branch December 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants