Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes leaking in the toggle switch component #10035

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 7, 2024

Small one to fix the attributes leaking in the <f:toggleSwitch /> component. It was missing attrs. which caused some properties to inherit prior set values.

Testing done

  • Toggle switch works as expected in project views/Design Library

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Dec 7, 2024
@timja timja requested a review from a team December 7, 2024 19:14
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 8, 2024
@krisstern
Copy link
Member

If there is no objection this PR will be merged in 24 hours

@krisstern krisstern merged commit fa35f03 into jenkinsci:master Dec 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants