-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make aborted and disabled icon colours themable #10032
base: master
Are you sure you want to change the base?
Make aborted and disabled icon colours themable #10032
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - need to confirm this is needed though jenkinsci/dark-theme-plugin#550 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to understand this before we proceed:
jenkinsci/dark-theme-plugin#550 (comment)
but once thats understood this is good
@janfaracik has figured it out in jenkinsci/dark-theme-plugin#550 (comment) This needs fixing in branch-api-plugin |
Alternatively adapting |
Update the aborted and disabled icon colours to be set from variables instead of hard coded colours, allowing them to be overwritten by themes.
See:
jenkinsci/dark-theme-plugin#550
jenkinsci/dark-theme-plugin#552
Testing done
No tests written as is a pure UI update
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@timja
Before the changes are marked as
ready-for-merge
:Maintainer checklist