[JENKINS-72505] f:validateButton finds selected radio button (#8832)

JENKINS-72505 f:validateButton finds selected radio button Co-authored-by: Mark Waite <[email protected]> Co-authored-by: Alexander Brandes <[email protected]>
jenkinsci · Jan 26, 2024 · d2a9fd2 · d2a9fd2
1 parent 8088f30
commit d2a9fd2
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/test/src/test/java/lib/form/ValidateButtonTest.java b/test/src/test/java/lib/form/ValidateButtonTest.java
@@ -109,13 +109,16 @@ public static final class DescriptorImpl extends Descriptor<TestValidateIsCalled
 
             public void doValidateTest1(@QueryParameter("a") String a, @QueryParameter("b") boolean b,
                                         @QueryParameter("c") boolean c, @QueryParameter("d") String d,
-                                        @QueryParameter("e") String e) {
+                                        @QueryParameter("e") String e,
+                                        @QueryParameter("f") String f
+                                        ) {
                 try {
                     assertEquals("avalue", a);
                     assertTrue(b);
                     assertFalse(c);
                     assertEquals("dvalue", d);
                     assertEquals("e2", e);
+                    assertEquals("f", f);
                     test1Outcome = null;
                 } catch (RuntimeException t) {
                     test1Outcome = t;

diff --git a/test/src/test/resources/lib/form/ValidateButtonTest/TestValidateIsCalled/index.jelly b/test/src/test/resources/lib/form/ValidateButtonTest/TestValidateIsCalled/index.jelly
@@ -50,7 +50,27 @@ THE SOFTWARE.
           <f:option value="e2" selected="true">e2</f:option>
         </select>
       </f:entry>
-      <f:validateButton method="validateTest1" title="test" with="a,b,c,d,e" />
+
+      <f:entry title="f">
+        <f:radioBlock name="f" value="notf" title="fa" checked="false">
+          <f:entry title="fa">
+            <f:textbox name="fa"/>
+          </f:entry>
+        </f:radioBlock>
+
+        <f:radioBlock name="f" value="f" title="fb" checked="true">
+          <f:entry title="fb">
+            <f:textbox name="fb"/>
+          </f:entry>
+        </f:radioBlock>
+
+        <f:radioBlock name="f" value="reallynotf" title="fb" checked="false">
+          <f:entry title="fc">
+            <f:textbox name="fc"/>
+          </f:entry>
+        </f:radioBlock>
+      </f:entry>
+      <f:validateButton method="validateTest1" title="test" with="a,b,c,d,e,f" />
     </f:form>
   </l:main-panel>
 </l:layout>

diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -2708,8 +2708,13 @@ function validateButton(checkUrl, paramList, button) {
   paramList.split(",").forEach(function (name) {
     var p = findPreviousFormItem(button, name);
     if (p != null) {
-      if (p.type == "checkbox") {
+      if (p.type === "checkbox") {
         parameters[name] = p.checked;
+      } else if (p.type === "radio") {
+        while (p && !p.checked) {
+          p = findPreviousFormItem(p, name);
+        }
+        parameters[name] = p.value;
       } else {
         parameters[name] = p.value;
       }