review

jenkinsci · Oct 17, 2023 · 6055faa · 6055faa
1 parent 43569ea
commit 6055faa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java b/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java
@@ -115,7 +115,8 @@ public DiskSpace markNodeOfflineIfDiskspaceIsTooLow(Computer c) {
         long threshold = getThresholdBytes(c);
         if (size != null) {
             size.setThreshold(threshold);
-            size.setWarningThreshold(getWarningThresholdBytes(c));
+            long warningThreshold = getWarningThresholdBytes(c);
+            size.setWarningThreshold(warningThreshold);
             if (size.size < threshold) {
                 size.setTriggered(this.getClass(), true);
                 if (getDescriptor().markOffline(c, size)) {

diff --git a/core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java b/core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
@@ -124,7 +124,7 @@ public boolean isTriggered() {
 
         @Restricted(NoExternalUse.class)
         public boolean isWarning() {
-            return warningThreshold > 0 && size < warningThreshold;
+            return size > threshold && size < warningThreshold ;
         }
 
         /**