[JENKINS-74795] createItem API should not assign new jobs to default …

…view

Behavior in 2.474 and earlier was to not assign new jobs to the default
view.  Unfortunately, there was no automated test to check that case.

core/src/main/java/hudson/model/ListView.java

@@ -366,8 +366,8 @@ private boolean needToAddToCurrentView(StaplerRequest2 req) throws ServletExcept
             JSONObject form = req.getSubmittedForm();
             return form.has("addToCurrentView") && form.getBoolean("addToCurrentView");
         } else {
-            // Submitted via API
-            return true;
+            // Submitted via API - JENKINS-74975
+            return false;
         }
     }
 

test/src/test/java/hudson/jobs/CreateItemTest.java

@@ -38,12 +38,10 @@
 import hudson.model.ItemGroup;
 import hudson.model.ListView;
 import hudson.model.listeners.ItemListener;
-import hudson.util.VersionNumber;
 import java.net.HttpURLConnection;
 import java.net.URI;
 import java.net.URL;
 import java.text.MessageFormat;
-import jenkins.model.Jenkins;
 import org.htmlunit.HttpMethod;
 import org.htmlunit.Page;
 import org.htmlunit.WebRequest;
@@ -114,14 +112,7 @@ public void testCreateItemDoesNotPopulateDefaultView() throws Exception {
 
         // Confirm new job is not visible in default view
         assertTrue(aView.isDefault()); // a-view is still the default view
-        VersionNumber jenkinsVersion = Jenkins.getVersion();
-        if (jenkinsVersion == null || jenkinsVersion.isOlderThan(new VersionNumber("2.475"))) {
-            // TODO: When JENKINS-74795 is fixed, this assertion will pass
-            assertThat(aView.getItems(), containsInAnyOrder(aJob));
-        } else {
-            // TODO: Until JENKINS-74795 is fixed, this assertion passes (a bug)
-            assertThat(aView.getItems(), containsInAnyOrder(aJob, b2Job));
-        }
+        assertThat(aView.getItems(), containsInAnyOrder(aJob));
     }
 
     @Issue("JENKINS-31235")

test/src/test/java/hudson/model/ItemsTest.java

@@ -28,7 +28,6 @@
 import static org.hamcrest.Matchers.containsInAnyOrder;
 import static org.hamcrest.Matchers.empty;
 import static org.hamcrest.Matchers.is;
-import static org.hamcrest.Matchers.not;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
@@ -41,7 +40,6 @@
 import hudson.cli.CopyJobCommand;
 import hudson.cli.CreateJobCommand;
 import hudson.security.ACL;
-import hudson.util.VersionNumber;
 import java.io.ByteArrayInputStream;
 import java.io.File;
 import java.net.HttpURLConnection;
@@ -210,7 +208,7 @@ private void createPrimaryView() throws Exception {
     }
 
     /* JENKINS-74795 notes that new items created through the REST API
-     * are made visible in the default view with 2.475 and newer.
+     * are made visible in the default view with 2.475-2.483.
      * They were not made visible in the default view with 2.474 and
      * earlier.
      */