fix: serialVersionUID fix for most of the cases found and removed inc…

…onsistency

core/src/main/java/hudson/EnvVars.java

@@ -73,7 +73,7 @@
  * @author Kohsuke Kawaguchi
  */
 public class EnvVars extends TreeMap<String, String> {
-    private static final long serialVersionUID = 4320331661987259022L;
+    private static final long serialVersionUID = 1L;
     private static Logger LOGGER = Logger.getLogger(EnvVars.class.getName());
     /**
      * If this {@link EnvVars} object represents the whole environment variable set,

core/src/main/java/hudson/FilePath.java

@@ -187,7 +187,7 @@
  * // if 'file' is on a different node, this FileCallable will
  * // be transferred to that node and executed there.
  * private static final class Freshen implements FileCallable<Void> {
- *     private static final long serialVersionUID = 1;
+ *     private static final long serialVersionUID = 1L;
  *     @Override public Void invoke(File f, VirtualChannel channel) {
  *         // f and file represent the same thing
  *         f.deleteContents();
@@ -1791,7 +1791,7 @@ private static class Touch extends MasterToSlaveFileCallable<Void> {
             this.timestamp = timestamp;
         }
 
-            private static final long serialVersionUID = -5094638816500738429L;
+            private static final long serialVersionUID = 1L;
 
             @Override
             public Void invoke(File f, VirtualChannel channel) throws IOException {
@@ -1819,7 +1819,7 @@ private static class SetLastModified extends MasterToSlaveFileCallable<String> {
             this.timestamp = timestamp;
         }
 
-            private static final long serialVersionUID = -828220335793641630L;
+            private static final long serialVersionUID = 1L;
 
             @Override
             public String invoke(File f, VirtualChannel channel) throws IOException {
@@ -2675,7 +2675,7 @@ public void copyTo(OutputStream os) throws IOException, InterruptedException {
     }
 
     private static class CopyTo extends MasterToSlaveFileCallable<Void> {
-        private static final long serialVersionUID = 4088559042349254141L;
+        private static final long serialVersionUID = 1L;
         private final OutputStream out;
 
         CopyTo(OutputStream out) {
@@ -3182,7 +3182,7 @@ private static class ValidateAntFileMask extends MasterToSlaveFileCallable<Strin
             this.bound = bound;
         }
 
-            private static final long serialVersionUID = 1;
+            private static final long serialVersionUID = 1L;
 
             @Override
             public String invoke(File dir, VirtualChannel channel) throws IOException, InterruptedException {
@@ -3636,7 +3636,7 @@ public FilePath call() throws IOException {
      */
     public static final class ExplicitlySpecifiedDirScanner extends DirScanner {
 
-        private static final long serialVersionUID = 1;
+        private static final long serialVersionUID = 1L;
 
         private final Map<String, String> files;
 

core/src/main/java/hudson/Functions.java

@@ -1514,7 +1514,7 @@ protected int compare(long idA, long idB) {
 
     public static class ThreadGroupMap extends ThreadSorterBase implements Comparator<ThreadInfo>, Serializable {
 
-        private static final long serialVersionUID = 7803975728695308444L;
+        private static final long serialVersionUID = 1L;
 
         /**
          * @return ThreadGroup name or null if unknown
@@ -1534,7 +1534,7 @@ public int compare(ThreadInfo a, ThreadInfo b) {
 
     private static class ThreadSorter extends ThreadSorterBase implements Comparator<Thread>, Serializable {
 
-        private static final long serialVersionUID = 5053631350439192685L;
+        private static final long serialVersionUID = 1L;
 
         @Override
         public int compare(Thread a, Thread b) {

core/src/main/java/hudson/cli/SetBuildDescriptionCommand.java

@@ -12,7 +12,7 @@
 @SuppressFBWarnings(value = "SE_NO_SERIALVERSIONID", justification = "The Serializable should be removed.")
 @Extension
 public class SetBuildDescriptionCommand extends CLICommand implements Serializable {
-    private static final long serialVersionUID = -7269184394646019447L;
+    private static final long serialVersionUID = 1L;
 
     @Override
     public String getShortDescription() {

core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java

@@ -9,7 +9,7 @@
 
 @Extension
 public class SetBuildDisplayNameCommand extends CLICommand implements Serializable {
-    private static final long serialVersionUID = 6665171784136358536L;
+    private static final long serialVersionUID = 1L;
 
     @Override
     public String getShortDescription() {

core/src/main/java/hudson/console/HyperlinkNote.java

@@ -111,5 +111,5 @@ public String getDisplayName() {
     }
 
     private static final Logger LOGGER = Logger.getLogger(HyperlinkNote.class.getName());
-    private static final long serialVersionUID = 3908468829358026949L;
+    private static final long serialVersionUID = 1L;
 }

core/src/main/java/hudson/logging/LogRecorder.java

@@ -364,7 +364,7 @@ public void disable() {
 
     private static class TargetComparator implements Comparator<Target>, Serializable {
 
-        private static final long serialVersionUID = 9285340752515798L;
+        private static final long serialVersionUID = 1L;
 
         @Override
         public int compare(Target left, Target right) {

core/src/main/java/hudson/model/FileParameterValue.java

@@ -66,7 +66,7 @@
 public class FileParameterValue extends ParameterValue {
     private static final String FOLDER_NAME = "fileParameters";
     private static final Pattern PROHIBITED_DOUBLE_DOT = Pattern.compile(".*[\\\\/]\\.\\.[\\\\/].*");
-    private static final long serialVersionUID = -143427023159076073L;
+    private static final long serialVersionUID = 1L;
 
     /**
      * Escape hatch for SECURITY-1074, fileParameter used to escape their expected folder.

core/src/main/java/hudson/model/HealthReport.java

@@ -63,7 +63,7 @@ public class HealthReport implements Serializable, Comparable<HealthReport> {
     private static final String HEALTH_UNKNOWN_IMG = "empty.png";
 
     private static final Map<String, String> iconIMGToClassMap = new HashMap<>();
-    private static final long serialVersionUID = 7451361788415642230L;
+    private static final long serialVersionUID = 1L;
 
     static {
         iconIMGToClassMap.put(HEALTH_OVER_80_IMG, HEALTH_OVER_80);
@@ -355,7 +355,7 @@ public static HealthReport max(HealthReport a, HealthReport b) {
      * Fix deserialization of older data.
      */
     public static class ConverterImpl extends XStream2.PassthruConverter<HealthReport> {
-        private static final long serialVersionUID = -1L;
+        private static final long serialVersionUID = 1L;
         public ConverterImpl(XStream2 xstream) { super(xstream); }
 
         @Override protected void callback(HealthReport hr, UnmarshallingContext context) {

core/src/main/java/hudson/model/JDK.java

@@ -64,7 +64,7 @@ public final class JDK extends ToolInstallation implements NodeSpecific<JDK>, En
      * @since 1.577
      */
     public static final String DEFAULT_NAME = "(System)";
-    private static final long serialVersionUID = -3318291200160313357L;
+    private static final long serialVersionUID = 1L;
 
     @Restricted(NoExternalUse.class)
     public static boolean isDefaultName(String name) {

core/src/main/java/hudson/model/Label.java

@@ -211,7 +211,7 @@ public boolean isSelfLabel() {
     }
 
     private static class NodeSorter implements Comparator<Node>, Serializable {
-        private static final long serialVersionUID = -7368519598046684532L;
+        private static final long serialVersionUID = 1L;
 
         @Override
         public int compare(Node o1, Node o2) {

core/src/main/java/hudson/model/ParameterValue.java

@@ -77,7 +77,7 @@
 @ExportedBean(defaultVisibility = 3)
 @StaplerAccessibleType
 public abstract class ParameterValue implements Serializable {
-    private static final long serialVersionUID = -7269184774646019967L;
+    private static final long serialVersionUID = 1L;
 
     private static final Logger LOGGER = Logger.getLogger(ParameterValue.class.getName());
 

core/src/main/java/hudson/model/Slave.java

@@ -101,7 +101,7 @@
  * @author Kohsuke Kawaguchi
  */
 public abstract class Slave extends Node implements Serializable {
-    private static final long serialVersionUID = -7267774394646019967L;
+    private static final long serialVersionUID = 1L;
     private static final Logger LOGGER = Logger.getLogger(Slave.class.getName());
 
     /**

core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java

@@ -153,7 +153,7 @@ private void error(Computer c, Throwable x) {
      * returns computers that was not monitored as they ware either offline or monitor produced {@code null} {@link Callable}.
      */
     protected static final class Result<T> {
-        private static final long serialVersionUID = -7671448355804481216L;
+        private static final long serialVersionUID = 1L;
 
         private final @NonNull Map<Computer, T> data;
         private final @NonNull ArrayList<Computer> skipped;

core/src/main/java/hudson/node_monitors/SwapSpaceMonitor.java

@@ -153,7 +153,7 @@ private <T extends Throwable> MemoryUsage report(T e) throws T {
      */
     @ExportedBean
     public static class MemoryUsage2 extends MemoryUsage {
-        private static final long serialVersionUID = 2216994637932270352L;
+        private static final long serialVersionUID = 1L;
 
         public MemoryUsage2(MemoryUsage mem) {
             super(mem.totalPhysicalMemory, mem.availablePhysicalMemory, mem.totalSwapSpace, mem.availableSwapSpace);

core/src/main/java/hudson/security/AuthorizationStrategy.java

@@ -213,7 +213,7 @@ public abstract class AuthorizationStrategy extends AbstractDescribableImpl<Auth
     public static final AuthorizationStrategy UNSECURED = new Unsecured();
 
     public static final class Unsecured extends AuthorizationStrategy implements Serializable {
-        private static final long serialVersionUID = -7269184394646019967L;
+        private static final long serialVersionUID = 1L;
         /**
          * Maintains the singleton semantics.
          */

core/src/main/java/hudson/security/FederatedLoginService.java

@@ -115,7 +115,7 @@ public abstract class FederatedLoginService implements ExtensionPoint {
      * Identity information as obtained from {@link FederatedLoginService}.
      */
     public abstract class FederatedIdentity implements Serializable {
-        private static final long serialVersionUID = -7269184394646019567L;
+        private static final long serialVersionUID = 1L;
         /**
          * Gets the string representation of the identity in the form that makes sense to the enclosing
          * {@link FederatedLoginService}, such as full OpenID URL.

core/src/main/java/hudson/slaves/ChannelPinger.java

@@ -125,7 +125,7 @@ public void install(Channel channel) {
     @VisibleForTesting
     @Restricted(NoExternalUse.class)
     public static class SetUpRemotePing extends MasterToSlaveCallable<Void, IOException> {
-        private static final long serialVersionUID = -2702219700841759872L;
+        private static final long serialVersionUID = 1L;
         @Deprecated
         private transient int pingInterval;
         private final int pingTimeoutSeconds;

core/src/main/java/hudson/tasks/ArtifactArchiver.java

@@ -296,7 +296,7 @@ public void perform(Run<?, ?> build, FilePath ws, EnvVars environment, Launcher
     }
 
     private static final class ListFiles extends MasterToSlaveFileCallable<Map<String, String>> {
-        private static final long serialVersionUID = 1;
+        private static final long serialVersionUID = 1L;
         private final String includes, excludes;
         private final boolean defaultExcludes;
         private final boolean caseSensitive;

core/src/main/java/hudson/tasks/LogRotator.java

@@ -65,7 +65,7 @@ public class LogRotator extends BuildDiscarder {
     /** @deprecated Replaced by more generic {@link CompositeIOException}. */
     @Deprecated
     public static class CollatedLogRotatorException extends IOException {
-        private static final long serialVersionUID = 5944233808072651101L;
+        private static final long serialVersionUID = 1L;
 
         public final Collection<Exception> collated;
 

core/src/main/java/hudson/tasks/Maven.java

@@ -250,7 +250,7 @@ private Object readResolve() {
      * name.
      */
     private static final class DecideDefaultMavenCommand extends MasterToSlaveFileCallable<String> {
-        private static final long serialVersionUID = -2327576423452215146L;
+        private static final long serialVersionUID = 1L;
         // command line arguments.
         private final String arguments;
 

core/src/main/java/hudson/tools/ToolInstallation.java

@@ -88,7 +88,7 @@
  */
 public abstract class ToolInstallation extends AbstractDescribableImpl<ToolInstallation>
         implements Serializable, ExtensionPoint {
-    private static final long serialVersionUID = -7261984394646019967L;
+    private static final long serialVersionUID = 1L;
 
     private static final Logger LOGGER = Logger.getLogger(ToolInstallation.class.getName());
 

core/src/main/java/hudson/util/AbstractTaskListener.java

@@ -13,6 +13,6 @@
 @RestrictedSince("2.91")
 public abstract class AbstractTaskListener implements TaskListener {
 
-    private static final long serialVersionUID = 7217626701881006422L;
+    private static final long serialVersionUID = 1L;
 
 }

core/src/main/java/hudson/util/ClasspathBuilder.java

@@ -15,7 +15,7 @@
  * @since 1.300
  */
 public class ClasspathBuilder implements Serializable {
-    private static final long serialVersionUID = -7269184387646019967L;
+    private static final long serialVersionUID = 1L;
 
     private final List<String> args = new ArrayList<>();
 

core/src/main/java/hudson/util/DirScanner.java

@@ -153,7 +153,7 @@ public void scan(File dir, FileVisitor visitor) throws IOException {
     }
 
     private static class DescendantFileSelector implements FileSelector {
-        private static final long serialVersionUID = 5L;
+        private static final long serialVersionUID = 1L;
         private final Set<String> alreadyDeselected;
         private final FilePath baseDirFP;
         private final int baseDirPathLength;

core/src/main/java/hudson/util/Secret.java

@@ -284,7 +284,7 @@ public Object unmarshal(HierarchicalStreamReader reader, final UnmarshallingCont
             return fromString(reader.getValue());
         }
 
-        private static final long serialVersionUID = 7269184394646019967L;
+        private static final long serialVersionUID = 1L;
     }
 
     /**

core/src/main/java/hudson/util/io/ParserConfigurator.java

@@ -56,7 +56,7 @@
  */
 @Deprecated
 public abstract class ParserConfigurator implements ExtensionPoint, Serializable {
-    private static final long serialVersionUID = -2523542286453177108L;
+    private static final long serialVersionUID = 1L;
 
     /**
      * Configures the given {@link SAXReader}
@@ -88,7 +88,7 @@ public static void applyConfiguration(SAXReader reader, Object context) throws I
     }
 
     private static class GetParserConfigurators extends SlaveToMasterCallable<Collection<ParserConfigurator>, IOException> {
-        private static final long serialVersionUID = -2178106894481500733L;
+        private static final long serialVersionUID = 1L;
 
         @Override
         public Collection<ParserConfigurator> call() throws IOException {

core/src/main/java/jenkins/model/IdStrategy.java

@@ -193,7 +193,7 @@ Character convertPseudoUnicode(String matchedGroup) {
      */
     public static class CaseInsensitive extends IdStrategy implements Serializable {
 
-        private static final long serialVersionUID = -7244768200684861085L;
+        private static final long serialVersionUID = 1L;
 
         @DataBoundConstructor
         public CaseInsensitive() {}
@@ -236,7 +236,7 @@ public String getDisplayName() {
      */
     public static class CaseSensitive extends IdStrategy implements Serializable {
 
-        private static final long serialVersionUID = 8339425353883308324L;
+        private static final long serialVersionUID = 1L;
 
         @DataBoundConstructor
         public CaseSensitive() {}
@@ -283,7 +283,7 @@ public String getDisplayName() {
      */
     public static class CaseSensitiveEmailAddress extends CaseSensitive implements Serializable {
 
-        private static final long serialVersionUID = -5713655323057260180L;
+        private static final long serialVersionUID = 1L;
 
         @DataBoundConstructor
         public CaseSensitiveEmailAddress() {}

core/src/main/java/jenkins/model/item_category/Category.java

@@ -41,7 +41,7 @@
 @ExportedBean
 @Restricted(NoExternalUse.class)
 public class Category implements Serializable {
-    private static final long serialVersionUID = 9269184394646019967L;
+    private static final long serialVersionUID = 1L;
 
     private String id;
 

core/src/main/java/jenkins/org/apache/commons/validator/routines/DomainValidator.java

@@ -75,7 +75,7 @@ public class DomainValidator implements Serializable {
     /** Maximum allowable length ({@value}) of a domain name */
     private static final int MAX_DOMAIN_LENGTH = 253;
 
-    private static final long serialVersionUID = -4407125112880174009L;
+    private static final long serialVersionUID = 1L;
 
     // Regular expression strings for hostnames (derived from RFC2396 and RFC 1123)
 

core/src/main/java/jenkins/org/apache/commons/validator/routines/InetAddressValidator.java

@@ -48,7 +48,7 @@ public class InetAddressValidator implements Serializable {
 
     private static final int BASE_16 = 16;
 
-    private static final long serialVersionUID = -919201640201914789L;
+    private static final long serialVersionUID = 1L;
 
     private static final String IPV4_REGEX =
             "^(\\d{1,3})\\.(\\d{1,3})\\.(\\d{1,3})\\.(\\d{1,3})$";

core/src/main/java/jenkins/org/apache/commons/validator/routines/RegexValidator.java

@@ -76,7 +76,7 @@
 // end of [PATCH]
 public class RegexValidator implements Serializable {
 
-    private static final long serialVersionUID = -8832409930574867162L;
+    private static final long serialVersionUID = 1L;
 
     private final Pattern[] patterns;
 

core/src/main/java/jenkins/org/apache/commons/validator/routines/UrlValidator.java

@@ -83,7 +83,7 @@
 // end of [PATCH]
 public class UrlValidator implements Serializable {
 
-    private static final long serialVersionUID = 7557161713937335013L;
+    private static final long serialVersionUID = 1L;
 
     private static final int MAX_UNSIGNED_16_BIT_INT = 0xFFFF; // port max
 

core/src/main/java/jenkins/tasks/SimpleBuildWrapper.java

@@ -210,7 +210,7 @@ public void setDisposer(@NonNull Disposer disposer) {
      */
     public abstract static class Disposer implements Serializable {
 
-        private static final long serialVersionUID = -7263485554646019967L;
+        private static final long serialVersionUID = 1L;
         @CheckForNull
         private Boolean wrapperRequiresWorkspace;