Introduce RealJenkinsRule.createSyntheticPlugin to allow synthetic plugins to be installed dynamically and break compatibility for existing callers of RealJenkinsRule.addSyntheticPlugin
#920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Feb 18, 2025
jglick
reviewed
Feb 18, 2025
jglick
reviewed
Feb 18, 2025
src/test/java/org/jvnet/hudson/test/RealJenkinsRuleSyntheticPluginTest.java
Outdated
Show resolved
Hide resolved
…d createSyntheticPlugin
dwnusbaum
commented
Feb 19, 2025
| @@ -40,7 +41,7 @@ public final class RealJenkinsRuleSyntheticPluginTest { | |||
| @Rule public RealJenkinsRule rr = new RealJenkinsRule().prepareHomeLazily(true); | |||
|
|
|||
| @Test public void smokes() throws Throwable { | |||
| rr.addSyntheticPlugin(Stuff.class.getPackage()).done(); | |||
| rr.addSyntheticPlugin(new SyntheticPlugin(Stuff.class.getPackage())); | |||
There was a problem hiding this comment.
The change is no longer backwards compatible, but this is all that needs to be done to adapt.
jglick
approved these changes
Feb 19, 2025
|
(Merge at will, if the revised API is being used successfully downstream.) |
dwnusbaum
changed the title
RealJenkinsRule.createSyntheticPlugin to allow synthetic plugins to be installed dynamically and break compatibility for existing callers of RealJenkinsRule.addSyntheticPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for jenkinsci/jenkins#10240.
Backwards-incompatible for most existing callers of
RealJenkinsRule.addSyntheticPlugin.Testing done
New automated test case added.
Submitter checklist