writeReplace should be protected when intended for use from subtypes #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Sep 23, 2020
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Sep 24, 2020
6 tasks
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Sep 28, 2020
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Sep 29, 2020
jvz
pushed a commit
to jenkinsci/jenkins
that referenced
this pull request
Nov 6, 2020
* Unforking XStream * Some overrides missing from MapperDelegate * [XSTR-762] writeReplace & readResolve must be accessible to be used from subclasses * DomElement.click overloads changed incompatibly * Giving up on ToolInstallation being Serializable. Fixing MavenInstallation accordingly. AntInstallation was already fixed: jenkinsci/ant-plugin@c957dca * Relaxing message assertion in RobustReflectionConverter.randomExceptionsReported * Picking up jenkinsci/matrix-auth-plugin#89 caught via JobTest * jenkinsci/jenkins-test-harness#243 released * Another case forgotten in 0e5aeec * XStream has SecurityMapper, but we have our own system already, so suppress warning * GetMavenVersion was also serializing its outer class * Trying to make ToolInstallation serializable compatible * Avoid throwing IOException from PersistedList.inModified for common cases covered by jenkinsci/jenkins-test-harness#243 * Found a way to avoid looking up XStream.converterRegistry by reflection * XStream2Test.crashXstream now throwing ConversionException, not ForbiddenClassException * Noting which version of the parent POM has jenkinsci/jenkins-test-harness#243 * Refreshed Javadoc for XStream2 * The simplest solution to JENKINS-19561 seems to be to stop using autodetectAnnotations * Fixing some deprecations in Robust*Converter * Display OldDataMonitor errors from RobustReflectionConverter during functional tests * Stray digit in test name * Added XStream2AnnotationTest to clearly document incompatibility * Picking up release of jenkinsci/matrix-auth-plugin#89 Co-authored-by: Basil Crow <[email protected]> Co-authored-by: Basil Crow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/jenkins#4944 needs compatibility with x-stream/xstream@4f5ea09: XSTR-762