Deprecate jelly:core "expr" tag in favor of "out" #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Apr 3, 2023
|
What does this PR accomplish? Is there some IDE magic that results in the Java class's deprecation marking uses of |
No, given you typically don't interface with the Java part of Jelly. That's just for us to know the reasoning behind the deprecation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jenkins, we rather use the "out" tag, over "expr". I would like to propose to deprecate the "expr" tag in favor of the now properly created and registered "out" tag. The description is taken from https://wiki.jenkins.io/display/JENKINS/Jelly+and+XSS+prevention
The "out" tag was registered with the same class the "expr" tag was. Hence, both have been a drop in for each other.