Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

SpotBugs violations #293

Merged
merged 1 commit into from
Oct 9, 2024
Merged

SpotBugs violations #293

merged 1 commit into from
Oct 9, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 9, 2024

Observable when updating parent POM to 5.1 (when using a newer jenkins.version).

@jglick jglick requested a review from a team as a code owner October 9, 2024 14:00
@MarkEWaite
Copy link
Contributor

Observable when updating parent POM to 5.1 (when using a newer jenkins.version).

Also observable on the master branch build with parent pom 4.88.

@jglick
Copy link
Member Author

jglick commented Oct 9, 2024

Indeed, as of c75d76c @centic9. I would recommend using pull request flow to ensure regressions are not accidentally pushed to trunk. No approvals are needed; you can just configure automerge to run once the Jenkins CI check passes.

@jglick
Copy link
Member Author

jglick commented Oct 9, 2024

(Or you can simply configure Dependabot or Renovate for dependency updates like this.)

@centic9 centic9 merged commit cc85322 into jenkinsci:master Oct 9, 2024
17 checks passed
@centic9
Copy link
Member

centic9 commented Oct 9, 2024

Thanks for fixing, it's always unexpected that changes to the "master" branch are picked up immediately and have all sorts of side effects in completely different places.

Unfortunately I feel the time has come for me to orphan this plugin as I do not actively maintain any Jenkins instance any more since quite some time.

Now I only need to find out how to do that...

@jglick
Copy link
Member Author

jglick commented Oct 9, 2024

@jglick jglick deleted the spotbugs branch October 9, 2024 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants