Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Override assignBuildNumber rather than saveNextBuildNumber #291

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 9, 2024

Avoids test failures due to (ab)use of EasyMock when running against jenkinsci/jenkins#9846.

I would appreciate a release after merge, to prevent problems in PCT.

@jglick jglick requested a review from a team as a code owner October 9, 2024 13:54
@Override
protected synchronized void saveNextBuildNumber() {
}
@Override
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore WS (tabs).

@jglick
Copy link
Member Author

jglick commented Oct 9, 2024

(CloudBees-internal issue)

@centic9 centic9 merged commit a5b8d3a into jenkinsci:master Oct 9, 2024
17 checks passed
@jglick jglick deleted the assignBuildNumber branch October 9, 2024 20:12
@jglick
Copy link
Member Author

jglick commented Nov 5, 2024

@centic9 can you please release this? jenkinsci/bom#3912 (comment)

(BTW I recommend setting up CD to make this sort of thing be less of a personal effort.)

@centic9
Copy link
Member

centic9 commented Nov 9, 2024

Did a release now, but I also orphaned the plugin now, hopefully someone else can take over.

darinpope added a commit to darinpope/bom that referenced this pull request Nov 10, 2024
basil pushed a commit to jenkinsci/bom that referenced this pull request Nov 10, 2024
@uhafner
Copy link
Member

uhafner commented Nov 16, 2024

Did a release now, but I also orphaned the plugin now, hopefully someone else can take over.

@centic9 I wonder if it wouldn't be better to rather mark the plugin as deprecated: its functionality is fully covered by the https://github.com/jenkinsci/coverage-plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants