Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes offline instructions due to removal of incrementals.url property #33

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

froque
Copy link
Member

@froque froque commented Jan 10, 2023

This is due to Maven 4 support [1].

Building plugins with Maven 4 (alpha) fails with:

'profiles.profile[consume-incrementals].repositories.repository.[incrementals].url' contains an expression but should be a constant. @ org.jenkins-ci.plugins:plugin:4.53

This has already been reported to Jenkins [2] and Maven [3] and was declared as an intentional change.

[1] jenkinsci/plugin-pom#666
[2] https://issues.jenkins.io/browse/JENKINS-67878
[3] https://issues.apache.org/jira/browse/MNG-7420

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This is due to Maven 4 support [1].

Building plugins with Maven 4 (alpha) fails with:
> 'profiles.profile[consume-incrementals].repositories.repository.[incrementals].url' contains an expression but should be a constant. @ org.jenkins-ci.plugins:plugin:4.53

This has already been reported to Jenkins [2] and Maven [3] and was
declared as an intentional change.

[1] jenkinsci/plugin-pom#666
[2] https://issues.jenkins.io/browse/JENKINS-67878
[3] https://issues.apache.org/jira/browse/MNG-7420
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

README.md Outdated Show resolved Hide resolved
Removes maven-release-plugin instructions because it is not used with incrementals

Co-authored-by: Basil Crow <[email protected]>
@jtnord
Copy link
Member

jtnord commented Jan 20, 2023

@jglick do you have access here? The upstream change in the plugin-pom has been merged.

jglick added a commit that referenced this pull request Jan 20, 2023
Did not get notified about #33 (comment)
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Did you actually try it? I have not personally run the offline testing in years.

@jglick jglick merged commit 8be1af4 into jenkinsci:master Jan 20, 2023
@jtnord
Copy link
Member

jtnord commented Jan 25, 2023

Looks fine. Did you actually try it? I have not personally run the offline testing in years.

@basil tested, reported here

@froque froque deleted the maven-4_incrementals.url branch February 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants