Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin super-linter to specific version #84

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

torstenwalter
Copy link
Member

@torstenwalter torstenwalter commented Oct 8, 2020

What this PR does / why we need it

Linting is broken with latest version of super-linter. It will try to lint Chart.yaml as Kubernetes manifest.

https://github.com/github/super-linter/blob/master/action.yml

The GitHub action refers to the v3 tag of the docker image:

name: 'Super-Linter'
author: 'GitHub'
description: 'It is a simple combination of various linters, written in bash, to help validate your source code.'
runs:
  using: 'docker'
  image: 'docker://ghcr.io/github/super-linter:v3'
branding:
  icon: 'check-square'
  color: 'white'

It's a floating tag as one can check in https://hub.docker.com/r/github/super-linter/tags

Kubeval was added in https://github.com/github/super-linter/releases/tag/v3.11.0

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • CHANGELOG.md was updated

https://github.com/github/super-linter/blob/master/action.yml

The GitHub action refers to the v3 tag of the docker image:

```yaml
name: 'Super-Linter'
author: 'GitHub'
description: 'It is a simple combination of various linters, written in bash, to help validate your source code.'
runs:
  using: 'docker'
  image: 'docker://ghcr.io/github/super-linter:v3'
branding:
  icon: 'check-square'
  color: 'white'
```

It's a floating tag as one can check in https://hub.docker.com/r/github/super-linter/tags

Kubeval was added in https://github.com/github/super-linter/releases/tag/v3.11.0

Signed-off-by: Torsten Walter <[email protected]>
@torstenwalter torstenwalter requested a review from a team as a code owner October 8, 2020 13:35
@torstenwalter torstenwalter merged commit 60a835f into jenkinsci:main Oct 8, 2020
@torstenwalter torstenwalter deleted the fix-linter branch October 8, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants