Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target port taken from values.yaml #74

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Conversation

kfirfer
Copy link
Contributor

@kfirfer kfirfer commented Sep 29, 2020

Related to issue #69

@kfirfer kfirfer requested a review from a team as a code owner September 29, 2020 20:41
Copy link
Member

@torstenwalter torstenwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only things missing are bumping the chart version in Chart.yaml and an entry in CHANGELOG.md

@torstenwalter torstenwalter merged commit 35fe7d0 into jenkinsci:main Oct 1, 2020
@torstenwalter
Copy link
Member

@kfirfer Thank you for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants