Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-73398: Support credential snapshots #334

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

mtughan
Copy link
Contributor

@mtughan mtughan commented Jul 3, 2024

Support taking snapshots of Vault secrets to allow them to be used properly on agents.

Testing done

Have run this locally in combination with jenkinsci/artifactory-artifact-manager-plugin#53 and it works a charm.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mtughan
Copy link
Contributor Author

mtughan commented Jul 3, 2024

@jenkinsci/hashicorp-vault-plugin-developers, please review when you have a chance.

@mtughan
Copy link
Contributor Author

mtughan commented Aug 21, 2024

@jenkinsci/hashicorp-vault-plugin-developers, any updates here? This PR seems to be languishing.

Support taking snapshots of Vault secrets to allow them to be used
properly on agents.
@jetersen jetersen merged commit d49bf74 into jenkinsci:master Aug 22, 2024
14 checks passed
@mtughan mtughan deleted the JENKINS-73398 branch August 22, 2024 12:34
@mtughan
Copy link
Contributor Author

mtughan commented Aug 22, 2024

Thanks @jetersen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants