Raise exception when access is denied instead of silently failing #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see an existing issue except for the PR in #163, but we've run into this recently and it caused some serious issues and was VERY surprising to me as I just thought things were working, but it was actually silently failing. |
bluesliverx
force-pushed
the
access-denied
branch
from
f0cca82 to
4d2ef3f
Compare
|
RETEST |
bluesliverx
force-pushed
the
access-denied
branch
from
4d2ef3f to
d7f66bb
Compare
|
Dear maintainers, this needs to be merged (unless you have a different change in place already) |
6 tasks
|
@jetersen I'm not sure if there are other maintainers here, but this PR has been open for nearly a year now. Any chance it could get a review/merge? We've been using it in our local fork with no issues in the last year. |
|
I have raised a Jenkins JIRA ticket to please merge this PR https://issues.jenkins.io/browse/JENKINS-72324 |
jetersen
approved these changes
Nov 14, 2023
|
released in 362.v8dfe4061f29e |
forest-code42
added a commit
to forest-code42/pipelinekt
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #163 in the way asked for by @jetersen, but also adds a unit test to ensure correct behavior. I chose not to base it on the failIfNotFound flag since access denied shows a configuration issue that should be addressed immediately instead of "I have permissions, but it just doesn't exist" that failIfNotFound is for.