Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume GroovyInstallation is serializable over Remoting #29

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Do not assume GroovyInstallation is serializable over Remoting #29

merged 1 commit into from
Sep 29, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 25, 2020 •
edited
Loading

As of jenkinsci/jenkins#4944 it will not be. Anyway the original implementation violated AnonymousClassWarnings.

Test coverage in #22 (awkward to add it in master).

@jglick jglick requested a review from vjuranek September 25, 2020 19:08
jglick referenced this pull request Sep 25, 2020
@olivergondza
Remove olivergondza from developer list
53b5452
@jglick jglick mentioned this pull request Sep 25, 2020
Merged
6 tasks
@olivergondza olivergondza merged commit 87f0c85 into jenkinsci:master Sep 29, 2020
@olivergondza
Copy link
Member

@jglick, 2.3 is released.

@jglick jglick deleted the GroovyInstallation branch September 29, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjuranek vjuranek Awaiting requested review from vjuranek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @olivergondza