Do not try to serialize GradleInstallation over Remoting #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@jglick Is this something I should merge? |
|
Yes, assuming of course you do not see any flaws in my refactoring. (Not sure if there is test coverage for this.) |
|
@jglick Thank you for the contribution. Is there any urgency in publishing a new version of the plugin including the change? |
I would not say “urgency” exactly but users of Gradle installations on agents using Jenkins weeklies will get stack traces dumped in their logs until you release this. When you do, please: https://github.com/jenkinsci/jep/edit/master/jep/228/compatibility.adoc |
|
I released 1.37.1 including these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with jenkinsci/jenkins#4944.