Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userinfo-email OAuth2 scope when associating service account #477

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

minhluantran017
Copy link

Background:

Service account associating with Jenkins agents provisioned by GCE plugin does not have the scope userinfo-email, which is suggested by official GKE docs to configure RBAC for the service account to deploy to GKE.

Proposal:

Add the userinfo-email OAuth2 scope beside current cloud-platform scope.

Github issue:

#476

Testing done

Local unit test passed using maven:3.8.6-openjdk-11:

[INFO] Results:
[INFO] 
[INFO] Tests run: 55, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  33:15 min
[INFO] Finished at: 2024-10-13T13:16:31Z
[INFO] ------------------------------------------------------------------------

@minhluantran017
Copy link
Author

Hi @evandbrown , @craigdbarber , @jtnord , @olamy ,
As you are maintainers, are you the right persons for reviewing this PR?
Thanks.

@jtnord jtnord requested a review from a team October 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant