Minor UX changes #173
Minor UX changes #173
Conversation
`exec` is not a real thing. There's `executable`, there's `exe`, but neither add value here.
| @@ -25,7 +25,7 @@ | |||
| <j:set var="APIInstance" value="${it.instance}" /> | |||
| <j:set var="cloud" value="${instance.cloud}" /> | |||
|
|
|||
| <h3>This is a read-only view. Click <a href="${rootURL}/configure"> here</a> to configure your instances.</h3> | |||
| <h3>This is a read-only view. Click <a href="${rootURL}/configureClouds/"> here</a> to configure your instances.</h3> | |||
There was a problem hiding this comment.
When testing this locally with mvn hpi:run, this didn't work. This is meant to point at the configure system page, which should be at "/configure"
There was a problem hiding this comment.
@daniel-beck changed this as of https://github.com/jenkinsci/jenkins/commits/jenkins-2.205 by jenkinsci/jenkins#4339 especially jenkinsci/jenkins@77f1242
It looks like LTS is currently 2.204.1 which means it just missed.
I guess once the next LTS arrives, I can include a change to the pom to bump the jenkins version which should result in your testing working.
google-compute-engine-plugin/pom.xml
Line 70 in 19e6cc8
Alternatively, I suppose w/ some amount of magic, I could ask jenkins if an endpoint exists and conditionally return the appropriate url.
There was a problem hiding this comment.
FWIW there's a placeholder in the existing configure page, so it's not like this is now wrong, just adds a level of indirection.
There was a problem hiding this comment.
From a UX perspective, getting a link to a page which just says you shouldn't be here is fairly insulting. That said, if the code path is inconsistent at this point, then either a branch in the code or a version bump at the next LTS seems warranted.
There was a problem hiding this comment.
jenkins version is currently set to 2.401.3 so this has long since past :)
There was a problem hiding this comment.
This URL has also been subsequently changed jenkinsci/jenkins#7658 in Jenkins version jenkins-2.403 to be manage/cloud/
Allthough there is a HTTP redirect in place for this.
| @@ -25,7 +25,7 @@ | |||
| <j:set var="APIInstance" value="${it.instance}" /> | |||
| <j:set var="cloud" value="${instance.cloud}" /> | |||
|
|
|||
| <h3>This is a read-only view. Click <a href="${rootURL}/configure"> here</a> to configure your instances.</h3> | |||
| <h3>This is a read-only view. Click <a href="${rootURL}/configureClouds/"> here</a> to configure your instances.</h3> | |||
There was a problem hiding this comment.
| <h3>This is a read-only view. Click <a href="${rootURL}/configureClouds/"> here</a> to configure your instances.</h3> | |
| <!-- TODO change the URL to ${rootURL}/manage/cloud/ when Jenkins version is 2.403 or higher --> | |
| <h3>This is a read-only view. Click <a href="${rootURL}/configureClouds/"> here</a> to configure your instances.</h3> |
amends jenkinsci#173 due to jenkinsci/jenkins#7658 bumps the baseline to avoid the redirect or adding a TODO
No description provided.