Optional check on secret in body to prevent Exceptions when using secretless Gogs > 0.10.x #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, so only do an optional check if it exists in the body
|
Hi Willem.. Is this PR still relevant? |
|
Hello, And yes for me/us this is still relevant. Because, we don't use a password for our Webhooks in dev environment. |
sanderv32
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when in Gogs > 0.10.x the secret is not set, the X-Gogs-Signature is empty. So only do an optional check if it exists in the body to prevent an Exception ( javax.servlet.ServletException: net.sf.json.JSONException: JSONObject["secret"] not found. ) when not found in the body
This is to fix #18