Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73344] Adapt GitLab for Jetty 12 (EE 9) #1665

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jun 21, 2024

@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests This PR adds/removes/updates test cases labels Jun 21, 2024
@basil basil changed the title Incremental build for testing (Jakarta) [JENKINS-73344] Prepare GitLab Jun 21, 2024
@basil basil changed the title [JENKINS-73344] Prepare GitLab [JENKINS-73344] Adapt GitLab for Jetty 12 (EE 9) Jun 21, 2024
@basil basil force-pushed the jakarta branch 2 times, most recently from 0f7a932 to 4ab1e02 Compare June 21, 2024 18:36
@basil basil marked this pull request as ready for review September 4, 2024 14:13
@basil basil requested a review from a team as a code owner September 4, 2024 14:13
@basil basil requested a review from krisstern September 4, 2024 14:13
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basil basil merged commit 0113160 into jenkinsci:master Sep 4, 2024
17 checks passed
@basil basil deleted the jakarta branch September 4, 2024 14:48
@basil
Copy link
Member Author

basil commented Sep 4, 2024

Thanks @krisstern! Can this please be released?

@krisstern
Copy link
Member

Sure @basil! Let me make a release now

@basil
Copy link
Member Author

basil commented Sep 4, 2024

Thank you very much!

@daniel-beck
Copy link
Member

This change broke mvn hpi:run:

[WARNING] Failed startup of context o.e.j.m.p.MavenWebAppContext@3e752d61{Jenkins v2.475,/jenkins,file:///Users/danielbeck/Repositories/github.com/jenkinsci/gitlab-plugin/target/jetty/webapp/,UNAVAILABLE}{/Users/danielbeck/.m2/repository/org/jenkins-ci/main/jenkins-war/2.475/jenkins-war-2.475.war}
java.lang.NoClassDefFoundError: jakarta/servlet/ServletContextListener
    at java.lang.ClassLoader.defineClass1 (Native Method)
    at java.lang.ClassLoader.defineClass (ClassLoader.java:1017)
    at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:150)
    at java.net.URLClassLoader.defineClass (URLClassLoader.java:524)
    at java.net.URLClassLoader$1.run (URLClassLoader.java:427)
    at java.net.URLClassLoader$1.run (URLClassLoader.java:421)
    at java.security.AccessController.doPrivileged (AccessController.java:712)
    at java.net.URLClassLoader.findClass (URLClassLoader.java:420)
    at org.eclipse.jetty.webapp.WebAppClassLoader.foundClass (WebAppClassLoader.java:594)
    at org.eclipse.jetty.webapp.WebAppClassLoader.loadAsResource (WebAppClassLoader.java:567)
    at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass (WebAppClassLoader.java:502)
    at java.lang.ClassLoader.loadClass (ClassLoader.java:525)

@krisstern
Copy link
Member

@basil Could you please take a look?

@basil
Copy link
Member Author

basil commented Sep 25, 2024

You'll need to run Maven with -Dhpi-plugin.version=3.58 until jenkinsci/plugin-pom#1004 is released and adopted.

@basil
Copy link
Member Author

basil commented Oct 4, 2024

Fixed in #1702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants