Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Issue 453 - NPE #454

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

drivera-armedia
Copy link
Contributor

@drivera-armedia drivera-armedia commented Oct 16, 2024

fixes #453

Testing done

  • Sandbox Jenkins environment
  • Production Jenkins environment

The patched plugin does the scanning correctly, and ensures that the NPE cannot happen, while preserving the desired functionality (i.e. forked project MRs are shown, non-forked projects are still scanned correctly).

This code cannot have an automated test due to the complexity required in the upstream GitLab projects. The changed lines were executed because the NPE no longer occurrs.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jetersen jetersen added the bug Something isn't working label Oct 16, 2024
@jetersen jetersen merged commit f7281bf into jenkinsci:master Oct 16, 2024
18 checks passed
@drivera-armedia drivera-armedia deleted the bugfix/issue-453-npe branch October 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants