[JENKINS-35118] Migrate to new parent POM #9
Conversation
| @@ -20,6 +20,11 @@ | |||
| <name>GitHub API Plugin</name> | |||
| <url>https://wiki.jenkins-ci.org/display/JENKINS/GitHub+API+Plugin</url> | |||
|
|
|||
| <properties> | |||
| <jenkins.version>1.565</jenkins.version> | |||
| <java.level>7</java.level> | |||
There was a problem hiding this comment.
okhttp has Java 7 level.
|
🐝 |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Is there anything else we need to do for this PR? |
| @@ -31,20 +36,27 @@ | |||
| <artifactId>okhttp-urlconnection</artifactId> | |||
| <version>2.5.0</version> | |||
| </dependency> | |||
| <!-- Solve dependency conflict in tests. --> | |||
There was a problem hiding this comment.
Better solution here, yes. Thanks!
|
🐝 |
| @@ -20,11 +20,22 @@ | |||
| <name>GitHub API Plugin</name> | |||
| <url>https://wiki.jenkins-ci.org/display/JENKINS/GitHub+API+Plugin</url> | |||
|
|
|||
| <properties> | |||
| <jenkins.version>1.615</jenkins.version> | |||
There was a problem hiding this comment.
Given that okhttp needs Java 7, let's bump baseline to the first version using Java 7.
There was a problem hiding this comment.
Well, most users of earlier lines use Java 7 or 8 anyway. OTOH pending JENKINS-20679 the only way to prevent accidental usage on Java 6 is to update the Jenkins version. So +0 on this.
Anyway, if you are going to update it, may as well go to the next LTS line: 1.625.x.
|
re:bee: |
|
🐝 Are we ready to merge? |
|
@andresrc you did the mess with version. 1.76 version was released with 1.75 library! |
See JENKINS-35118
@reviewbybees