Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump okhttp-api to 3.14.9 #57

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Bump okhttp-api to 3.14.9 #57

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7759ad9
Bump okhttp-api to 3.14.9
bitwiseman Jun 18, 2020
b6d5ef9
Update to final release from incremental
bitwiseman Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>okhttp-api</artifactId>
<version>3.12.12.2</version>
<version>3.14.9-rc25.7b0d25b3525e</version>
</dependency>
<dependency>
<groupId>org.kohsuke</groupId>
Expand Down Expand Up @@ -78,6 +78,14 @@
</exclusion>
</exclusions>
</dependency>

<!-- Included for backward compatibility, should be removed once downstream plugins are updated to use okhttp3 -->
<dependency>
<groupId>com.squareup.okhttp</groupId>
<artifactId>okhttp-urlconnection</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the other okhttp 2.x dependencies as well, or are they transitive dependencies of this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the main OkHttp library is a transitive dependency and is bundled as desired:

[INFO] Bundling direct dependency okhttp-urlconnection-2.7.5.jar
[WARNING] Bundling transitive dependency okhttp-2.7.5.jar (via okhttp-urlconnection)
[WARNING] Bundling transitive dependency commons-lang3-3.9.jar (via github-api)

<version>2.7.5</version>
</dependency>

</dependencies>

<!-- get every artifact through maven.glassfish.org, which proxies all the artifacts that we need -->
Expand Down