-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73132] Adapt GitHub API for Jetty 12 (EE 8) #249
[JENKINS-73132] Adapt GitHub API for Jetty 12 (EE 8) #249
Conversation
Superseded with #242 |
@vwagh-dev I believe that you mean this current pull request replaces pull request 242, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! Needs to also update the version of the plugin bill of materials (BOM).
Yes @alecharp you're right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The goal was to adapt the changes for Jetty 12 EE 8 for
github-api-plugin
see https://issues.jenkins.io/browse/JENKINS-73132.Also fixed the UT failures.
Closes #242.
Testing done
All tests are passing locally with
2.472-rc35224.f615612a_1850
as a2.472
(which is not yet released).Submitter checklist