Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73132] Adapt GitHub API for Jetty 12 (EE 8) #249

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

vwagh-dev
Copy link
Contributor

@vwagh-dev vwagh-dev commented Aug 13, 2024

The goal was to adapt the changes for Jetty 12 EE 8 for github-api-plugin see https://issues.jenkins.io/browse/JENKINS-73132.

Also fixed the UT failures.

Closes #242.

Testing done

All tests are passing locally with 2.472-rc35224.f615612a_1850 as a 2.472(which is not yet released).

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@vwagh-dev
Copy link
Contributor Author

vwagh-dev commented Aug 13, 2024

Superseded with #242

@alecharp
Copy link
Member

@vwagh-dev I believe that you mean this current pull request replaces pull request 242, correct?

Jenkinsfile Outdated Show resolved Hide resolved
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! Needs to also update the version of the plugin bill of materials (BOM).

pom.xml Show resolved Hide resolved
@vwagh-dev
Copy link
Contributor Author

@vwagh-dev I believe that you mean this current pull request replaces pull request 242, correct?

Yes @alecharp you're right

@vwagh-dev vwagh-dev changed the title [JENKINS-73132] Adapt GitHub API for Jetty 12 (EE 8) JENKINS-73132 Adapt GitHub API for Jetty 12 (EE 8) Aug 14, 2024
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@raul-arabaolaza raul-arabaolaza marked this pull request as ready for review August 14, 2024 10:29
@raul-arabaolaza raul-arabaolaza requested review from a team as code owners August 14, 2024 10:29
Copy link

@raul-arabaolaza raul-arabaolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alecharp alecharp added this pull request to the merge queue Aug 14, 2024
@alecharp alecharp changed the title JENKINS-73132 Adapt GitHub API for Jetty 12 (EE 8) [JENKINS-73132] Adapt GitHub API for Jetty 12 (EE 8) Aug 14, 2024
Merged via the queue into jenkinsci:master with commit f7ef628 Aug 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants