-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed outdated okhttp lib, and updated java native library changes #230
removed outdated okhttp lib, and updated java native library changes #230
Conversation
@@ -96,13 +96,6 @@ | |||
</exclusions> | |||
</dependency> | |||
|
|||
<!-- Included for backward compatibility, should be removed once downstream plugins are updated to use okhttp3 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been verified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, It has been verified and confirmed by @jtnord that "okhttp-urlconnnection 2.7.5" dependency need to be completely removed from the github-api-plugin and updated with the java native library changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The okhttp java native library changes made based on the the github-api release.
https://github.com/hub4j/github-api/releases/tag/github-api-1.300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amuniz . Yes The changes has been verified by running the usage-in-plugins under Rudi Controller. After running the job, I don't see any deprecated plugin usage. The verified link here:
https://gauntlet-3.cloudbees.com/rudi/job/usage-in-plugins/298/artifact/output/usage-by-plugin.html
Changes made as per the github-api release version recommended:
https://github.com/hub4j/github-api/releases/tag/github-api-1.300
The third party API "okhttp-urlconnection" was outdated. Need to remove the library from the github-api-plugin
Pom.xml
SmokeTest.java
mvn -D enable-ci clean install site
Testing Done: