Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plugin for December 2022 #190

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Refresh plugin for December 2022 #190

merged 2 commits into from
Mar 7, 2023

Conversation

basil
Copy link
Member

@basil basil commented Dec 16, 2022

Combines #152, #156, #166, #167, #169, #170, #174, #175, #179, #180, #187, and #188 into one PR for easy testing and also crosses the Java 11 flag day. Does not include #177 which is a risky upgrade that needs significant testing.

@basil basil requested review from a team as code owners December 16, 2022 21:10
@basil
Copy link
Member Author

basil commented Dec 16, 2022

Used my admin powers to replay the build with Jenkinsfile changes: https://ci.jenkins.io/job/Plugins/job/github-api-plugin/job/PR-190/2/

Tested this with jenkinsci/okhttp-api-plugin#129 downstream in github-branch-source-plugin. Apart from needing to fix Enforcer warnings related to Kotlin (which I did by importing kotlin-bom downstream), the upgrade passed.

@jglick jglick enabled auto-merge March 7, 2023 12:21
@jglick jglick mentioned this pull request Mar 7, 2023
@jglick jglick merged commit e35d9dd into jenkinsci:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants