Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwanted dependencies #15

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 13, 2017

@reviewbybees

@@ -50,6 +50,14 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</exclusion>
<exclusion> <!-- TODO pending https://github.com/kohsuke/github-api/pull/378 -->
<groupId>com.infradna.tool</groupId>
<artifactId>bridge-method-annotation</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hub4j/github-api#378; causes upper bounds problems

</exclusion>
<exclusion> <!-- provided by core -->
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin was needlessly bundling an unused redundant copy.

@ghost
Copy link

ghost commented Sep 13, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link

@vivek vivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐝

@jglick
Copy link
Member Author

jglick commented Sep 15, 2017

@reviewbybees done

@jglick jglick merged commit f6069bf into jenkinsci:master Sep 15, 2017
@jglick jglick deleted the bridge-method-annotation branch September 15, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants