-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unwanted dependencies #15
Conversation
@@ -50,6 +50,14 @@ | |||
<groupId>commons-codec</groupId> | |||
<artifactId>commons-codec</artifactId> | |||
</exclusion> | |||
<exclusion> <!-- TODO pending https://github.com/kohsuke/github-api/pull/378 --> | |||
<groupId>com.infradna.tool</groupId> | |||
<artifactId>bridge-method-annotation</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hub4j/github-api#378; causes upper bounds problems
</exclusion> | ||
<exclusion> <!-- provided by core --> | ||
<groupId>commons-lang</groupId> | ||
<artifactId>commons-lang</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugin was needlessly bundling an unused redundant copy.
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐝
@reviewbybees done |
@reviewbybees