Use spotbugs plugin 4.8.2.0 #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not risk compatibility by removing the private field.
Javadoc of the parent object states that the req argument will always be non-null, but cannot be annotated as non-null due to compatibility needs.
Preserve compatibility without allowing new additions to include public primitives.
Suppress the CT_CONSTRUCTUR_THROWS warning because it is not helpful in a Jenkins context. jenkinsci/plugin-pom#869 (comment) gives more details.
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use spotbugs plugin 4.8.2.0
Suppress the CT_CONSTRUCTUR_THROWS warning because it is not helpful in a Jenkins context. More details are available in jenkinsci/plugin-pom#869 (comment)
Suppress public primitive spotbugs warning for existing APIs. Preserve compatibility without allowing new additions to include public primitives.
Suppress null argument check for descriptor's newInstance. Javadoc of the parent object states that the req argument will always be non-null, but cannot be annotated as non-null due to compatibility needs.
Suppress unused field warning in GitSCM descriptor. Do not risk compatibility by removing the private field.
Checklist
Types of changes
Further comments
Changes to pom.xml will be removed once plugin pom includes the new settings.