Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Workflows when loading comment files #720

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nosmo
Copy link

@nosmo nosmo commented Nov 20, 2018

When a job is initiated via the pipeline plugin, the Run object is no longer an instance of Build, it becomes an instance of WorkflowRun. This means that the current logic for finding comment files on remote workers does not find the comment file when using a pipeline. Additionally, WorkflowRuns are more complex objects and they can have multiple associated workspaces.

This PR introduces support for finding the files on the remote workspaces.

This change does not allow for seamless discovery of the files in workspaces if multiple nodes are used, and users will be required to stash and unstash as is appropriate if using remote nodes, but I've included a documentation note to explain this.

(This is a repost of #682 - I was requested to re-file)

@Kentalot
Copy link

Kentalot commented Nov 21, 2018

looks like the same result :( Did you merge master into your branch? maybe the most recent merges don't play nice with your branch?

@nosmo nosmo force-pushed the u/hnowlan/add_workflow_support branch from 8760e30 to 7a8f844 Compare November 22, 2018 12:33
@nosmo
Copy link
Author

nosmo commented Nov 22, 2018

Looks like a rebase against master fixed it - not entirely sure why as tests look the same locally.

@Kentalot
Copy link

Yay! @samrocketman looks like this one can be approved and merged. Tests seem fixed!

Kentalot
Kentalot previously approved these changes Nov 27, 2018
@samrocketman
Copy link
Member

@nosmo seems the git author for your commits is off. Do you need to update the author? Otherwise your GitHub account would not be counted among the contributors.

@nosmo nosmo force-pushed the u/hnowlan/add_workflow_support branch 2 times, most recently from 8032884 to 7b23f2e Compare December 12, 2018 13:05
@nosmo
Copy link
Author

nosmo commented Dec 12, 2018

@samrocketman good catch - I've changed the author in commits.

@Kentalot
Copy link

now failed again haha

@nosmo nosmo force-pushed the u/hnowlan/add_workflow_support branch from 7b23f2e to 70b512f Compare January 23, 2019 12:18
@nosmo
Copy link
Author

nosmo commented Jan 23, 2019

Rebased and ran again, looks like they're passing.

@redwyre
Copy link

redwyre commented Jul 26, 2019

Any updates on this?

@pkazi
Copy link

pkazi commented Sep 27, 2020

Any update on this? Not able to use Comment file feature for Pipeline jobs which runs on slave nodes.

@fr-kqkq
Copy link

fr-kqkq commented Dec 8, 2020

Any update on this?

@TheSAS
Copy link

TheSAS commented Feb 18, 2021

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants