-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Workflows when loading comment files #720
base: master
Are you sure you want to change the base?
Conversation
looks like the same result :( Did you merge master into your branch? maybe the most recent merges don't play nice with your branch? |
8760e30
to
7a8f844
Compare
Looks like a rebase against master fixed it - not entirely sure why as tests look the same locally. |
Yay! @samrocketman looks like this one can be approved and merged. Tests seem fixed! |
@nosmo seems the git author for your commits is off. Do you need to update the author? Otherwise your GitHub account would not be counted among the contributors. |
8032884
to
7b23f2e
Compare
@samrocketman good catch - I've changed the author in commits. |
now failed again haha |
7b23f2e
to
70b512f
Compare
Rebased and ran again, looks like they're passing. |
Any updates on this? |
Any update on this? Not able to use |
Any update on this? |
Any updates? |
When a job is initiated via the pipeline plugin, the Run object is no longer an instance of Build, it becomes an instance of WorkflowRun. This means that the current logic for finding comment files on remote workers does not find the comment file when using a pipeline. Additionally, WorkflowRuns are more complex objects and they can have multiple associated workspaces.
This PR introduces support for finding the files on the remote workspaces.
This change does not allow for seamless discovery of the files in workspaces if multiple nodes are used, and users will be required to
stash
andunstash
as is appropriate if using remote nodes, but I've included a documentation note to explain this.(This is a repost of #682 - I was requested to re-file)