Skip default parameters that are null, to avoid NPE when building Environment #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Jenkins job has a parameter of a type that doesn't have a default value, the GHPRB plugin will throw a NullPointerException.
The declaration of
hudson.model.ParameterDefinition.getDefaultParameterValue()
explicitly allows null as a possible value by having the@CheckForNull
annotation.Such a parameter will result in
null
being added to the the list returned byGhprbTrigger.getDefaultParameters()
, which is then stored in theGhprbParametersAction
, which in turn will trigger an NPE when the environment is build.Here the full stacktrace: