Merge only works when trigger phrase is present #257 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,4 +72,19 @@ public void deleteOnMerge(boolean deleteOnMerge) { | |||
| public void deleteOnMerge() { | |||
| deleteOnMerge(true); | |||
| } | |||
|
|
|||
| /** | |||
| * Allows merging the PR even if the trigger phrase was not present. Dewfaults to {@code false} | |||
|
Other than the pom.xml changes I think everything looks good. |
|
retest please |
|
test this please |
|
@DavidTanner , your jenkins job seems to time out after 30 minutes. Slow download? |
|
I am not sure what is going on. That job is the main build that the Jenkins team set up, I have no control over it |
| <connection>scm:git:ssh://github.com/jenkinsci/ghprb-plugin.git</connection> | ||
| <developerConnection>scm:git:ssh://[email protected]/jenkinsci/ghprb-plugin.git</developerConnection> | ||
| <url>https://github.com/jenkinsci/ghprb-plugin</url> | ||
| <connection>scm:git:ssh://github.com/dulvac/ghprb-plugin.git</connection> |
There was a problem hiding this comment.
All changes to pom.xml need to be reverted here.
|
well... seems to work now |
|
@DavidTanner Anything else I can do? |
|
Hi guys, It is possible to merge this into master? |
|
+1, our team could really use this |
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Merge only works when trigger phrase is present jenkinsci#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new checkbox parameter to the merger post build action that allows merging without a trigger phrase if configured like that.