Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functionality to not post commit status for children jobs #333

Merged
merged 5 commits into from
May 20, 2016
Merged

Conversation

Eriten
Copy link
Contributor

@Eriten Eriten commented May 4, 2016

Updated Amrit's PR #309 with better code organization and DSL support.

To quote what Amrit describes about what this PR does,

It adds the ability to allow the user to not post commit statuses for the child job of a parent matrix job. If the checkbox is for this function is not pressed, it will follow its default behaviour.
I've added a checkbox in the config.jelly file that saves the value in "showMatrixStatus". The GhprbSimpleStatus class will read the value of the field. If the value is false it will create a commit status and proceed as normal (!showMatrixStatus). If the value is true, then will check if the project is a matrix project. Since the children jobs are not Matrix projects, we can avoid posting commit statuses for them by checking both the value of the box and if it is an instance of a matrix project (showMatrixStatus && build.getProject() instanceof MatrixProject)

@DavidTanner DavidTanner merged commit a3fa509 into jenkinsci:master May 20, 2016
nosmo pushed a commit to nosmo/ghprb-plugin that referenced this pull request Dec 12, 2018
Adding functionality to not post commit status for children jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants