TriggerMonitor: Fix grey icon anime bug and modernize icon animation #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new icon from jenkins build class and drop legacy icon Signed-off-by: Michael Trimarchi <[email protected]>
rsandell
approved these changes
Jan 9, 2024
mawinter69
reviewed
Jan 29, 2024
| @@ -44,7 +44,7 @@ | |||
| <j:choose> | |||
| <j:when test="${other.hasBuild()}"> | |||
| <td width="18"> | |||
| <img src="${imagesURL}/16x16/${other.build.iconColor.image}"/> | |||
| <l:icon class="${build.build.iconColor.iconClassName}"/> | |||
There was a problem hiding this comment.
Shouldn't that be other.build.iconColor.iconClassName?
Also in line 57 the change to <l:icon class="icon-grey-anime icon-sm"/> is missing similar to the change in ajaxTriggerMonitor.jelly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new icon from jenkins build class and drop legacy icon
Falling this conversation jenkinsci/jenkins#8806
The grey animation and grey icon are dropped from jenkins core. We need to move to use the new way
Testing done
Deploy plugin in my jenkins instance