Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with modern buttons #11

Closed
wants to merge 1 commit into from

Conversation

timja
Copy link
Member

@timja timja commented Nov 14, 2021

@jglick
Copy link
Member

jglick commented Nov 15, 2021

WDYT about simply inlining this functionality into Jenkins core? Other than very slightly larger HTML, I do not see any downside, and it would make ATH easier to maintain. (Might also be useful for HtmlUnit tests from JenkinsRule.)

@timja
Copy link
Member Author

timja commented Nov 15, 2021

WDYT about simply inlining this functionality into Jenkins core? Other than very slightly larger HTML, I do not see any downside, and it would make ATH easier to maintain. (Might also be useful for HtmlUnit tests from JenkinsRule.)

Hmm not sure, likely a fair bit of html bloat.

@timja
Copy link
Member Author

timja commented Nov 15, 2021

The other option would be to convert this plugin to enabling the core functionality?

and allow enabling it with a system property.

I’d be happier with that, any thoughts?

@jglick
Copy link
Member

jglick commented Nov 15, 2021

convert this plugin to enabling the core functionality?

and allow enabling it with a system property.

That sounds reasonable too.

@jglick
Copy link
Member

jglick commented Dec 1, 2021

Obsolete.

@jglick jglick closed this Dec 1, 2021
@timja timja deleted the modern-button-compat branch December 1, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants