Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tagging for Instance Network Interface #995

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

drullar
Copy link
Contributor

@drullar drullar commented Oct 17, 2024

Change description: Added tagging for a Node's Networking Interface, previously only the provisioned instance and it's EBS volume were tagged.
No tests were added for this, as from what I saw there were no tests for the instance and volume tagging and it seemed pointless to mock such a cosmetic change.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@res0nance res0nance added the enhancement Feature additions or enhancements label Nov 4, 2024
@res0nance res0nance merged commit 8ce0171 into jenkinsci:master Nov 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature additions or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants