Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for programmatic update of a SlaveTemplate #987

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

drullar
Copy link
Contributor

@drullar drullar commented Oct 1, 2024

PR Description

Added functionallity that would allow programmatic update of SlaveTemplates, which can be done by specifying the "old" SlaveTemplate's description. In case a template with the provided description does not exist, an exception is thrown. This feature is useful when someone wants to manage the SlaveTemplates programatically via the Jenkins Script feature.

Testing done

Added an Unit test for the new EC2Cloud method. Attached screenshot of local test execution
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@drullar
Copy link
Contributor Author

drullar commented Oct 1, 2024

Note: I am not sure what is your proceedure on updating the ReadMe. If needbe I can make edits and add description for the programmatic addition and update of a SlaveTemplate

@res0nance res0nance added the enhancement Feature additions or enhancements label Oct 7, 2024
@res0nance
Copy link
Contributor

Would you kindly add a section for it in the readme?

@drullar
Copy link
Contributor Author

drullar commented Oct 7, 2024

Added. Let me know if it needs any corrections

@res0nance res0nance merged commit b9e9e84 into jenkinsci:master Oct 8, 2024
17 checks passed
@drullar drullar deleted the prommatic-slavetemplate-update branch October 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature additions or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants