Add sidebar to Docker build action #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
the
enhancement
|
The Docker Image Build / Publish page was broken as a namespace was missing, fixed in 34429d4 if you run on a docker agent and do an image build / publish the sidebar is broken because it uses the same url path for different actions: 
Other than that this looks good |
|
Thanks, I fixed that pre-existing problem in commit 5afb80d |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed really weird to me that this page wouldn't have a sidebar like everything else. I looked at other run actions and they generally seemed to have a sidebar. To test this I loaded the Docker Build Data page and verified it had a sidebar.
CC @jenkinsci/sig-ux