Trivial support for ipv6 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully tested on proprietary runs of both the ATH and the PCT |
jglick
reviewed
Jan 26, 2024
src/main/java/org/jenkinsci/test/acceptance/docker/DockerContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/test/acceptance/docker/DockerContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/test/acceptance/docker/DockerContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/test/acceptance/docker/DockerContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/test/acceptance/docker/DockerContainer.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by some proprietary code I believe this could also be interesting to the community.
While arguably we want to stop using this library and move to test containers this change is so small that I can not resist to contribute it back. There may be a potential effort on migrating the ath and plugin tests to test containers that I totally endorse, but nothing prevents us to do that and this in parallel given the test containers migration is gonna require more effort.
Testing done
Submitter checklist