Introduce REMOTING_OPTS to pass arbitrary options to remoting on startup via an environment variable
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tup via an environment variable
Vlatombe
changed the title
REMOTING_OPTS to pass arbitrary options to remoting on startup via an environment variable
1 task
jglick
approved these changes
May 15, 2024
There was a problem hiding this comment.
Should be decided what to do when both systems (command-line options, specific environment variables) are used and fail-fast accordingly.
I do not think we need to make it unnecessarily complicated; there is already too much code that tries to be clever this way, but Launcher itself should detect inappropriate option combinations and produce appropriate error messages.
I would suggest moving the new option to the top of the description, and noting that it supersedes all prior options except for JAVA_BIN and JAVA_OPTIONS and that use of those is now deprecated.
jglick
approved these changes
May 15, 2024
Vlatombe
added a commit
to Vlatombe/kubernetes-plugin
that referenced
this pull request
May 16, 2024
Add system properties based switches to use the new mechanism To enable usage of REMOTING_OPTS -Dorg.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilder.useRemotingOpts=true Enabling it requires all pod templates to use a version of agent with jenkinsci/docker-agent#809 in. Add extra REMOTING options -Dorg.csanchez.jenkins.plugins.kubernetes.PodTemplateBuilder.extraRemotingOpts="-noReconnectAfter 10m" Used this approach because there are migration challenges: * The remoting version must be recent enough to support REMOTING_OPTS * When overriding the JNLP container, the configuration form is generic, and part of REMOTING_OPTS is generated based on options defined in the cloud, so can't expose either an "extra remoting options" field, not use the `REMOTING_OPTS` environment variable.
dduportal
approved these changes
May 17, 2024
lemeurherve
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#802 (comment)
This deprecates existing environment variables allowing to set options to
agent.jar. Going forward, this will ease addition or removal of options toagent.jarwithout impacting these launcher scripts.Testing done
Submitter checklist