Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes on dialogs page #383

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

mawinter69
Copy link
Contributor

avoid javascript errors
default for quantity
form submission page redesign so the sidepanel style is not broken

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

avoid javascript errors
default for quantity
form submission page redesign to have properly styled sidepanel
@mawinter69 mawinter69 requested a review from a team as a code owner January 5, 2025 19:12
Copy link
Contributor

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janfaracik janfaracik merged commit b7f9359 into jenkinsci:master Jan 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants