-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display plugin version on home page #369
Conversation
Looks like all CI/CD checks are passing on GitHub |
src/main/resources/io/jenkins/plugins/designlibrary/Home/index.jelly
Outdated
Show resolved
Hide resolved
Few small changes requested - thanks! |
Co-authored-by: Jan Faracik <[email protected]>
|
That's the SNAPSHOT version when running locally, once it's deployed it'll show the actual release version. Nothing to worry about :) |
|
||
public String getPluginVersion() { | ||
Jenkins jenkins = Jenkins.get(); | ||
if (jenkins != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove this if
block as Jenkins cannot be null
. (My first assumption was wrong. Jenkins null
handling actually is very ugly)
Added the desired changes , now it's failing because of that spotless issue. I had applied mvn spotless:apply locally then pushed however this showed error when pushed. This has happened to me before too , I don't know why. |
Thanks for your guidance @uhafner @janfaracik . I've applied the required changes. If further changes are needed , I can work on them too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple small tweaks, looks good to me! Thanks for contributing. I'll merge if you're happy @uhafner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the null handling is fine! Thanks for the PR!
Welcome and thanks again for your guidance !! |
Fixes #362
Added plugin version at the footer of home page.
Testing done
Local testing
Submitter checklist