Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update banners to use new css classes #327

Merged
merged 3 commits into from
May 21, 2024
Merged

update banners to use new css classes #327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5223f5
update banners to use new css classes
mawinter69 May 18, 2024
7583a47
Update src/main/resources/io/jenkins/plugins/designlibrary/Banner/ind…
mawinter69 May 18, 2024
5e99851
Update to 2.459
mawinter69 May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ THE SOFTWARE.
<properties>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/design-library-plugin</gitHubRepo>
<jenkins.version>2.450</jenkins.version>
<jenkins.version>2.458-rc34917.4f74a_6216e6d</jenkins.version>
mawinter69 marked this conversation as resolved.
Show resolved Hide resolved
<node.version>20.12.2</node.version>
<npm.version>10.2.5</npm.version>
</properties>
Expand Down
12 changes: 8 additions & 4 deletions src/main/resources/io/jenkins/plugins/designlibrary/Banner/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,24 @@
</div>
<div class="jdl-component-group">
<div class="jdl-component-sample jdl-component-sample--full-width jdl-component-sample--gridless">
<div class="alert alert-info">
<div class="jenkins-alert jenkins-alert-info">
Hello world
</div>
<div class="alert alert-warning">
<div class="jenkins-alert jenkins-alert-warning">
Hello world
</div>
<div class="alert alert-danger">
<div class="jenkins-alert jenkins-alert-danger">
Hello world
</div>
<div class="alert alert-success jenkins-!-margin-bottom-0">
<div class="jenkins-alert jenkins-alert-success jenkins-!-margin-bottom-0">
Hello world
</div>
</div>
<s:code language="xml" file="index.jelly" />
</div>
<div class="jenkins-alert jenkins-alert-warning">
Since 2.459. The css classes have been without the <em>jenkins-</em> prefix in older versions and can still be used but they might interfere with
mawinter69 marked this conversation as resolved.
Show resolved Hide resolved
classes defined in bootstrap.
</div>
</s:sample>
</j:jelly>
8 changes: 4 additions & 4 deletions src/main/webapp/Banner/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<div class="alert alert-info">
<div class="jenkins-alert jenkins-alert-info">
Hello world
</div>
<div class="alert alert-warning">
<div class="jenkins-alert jenkins-alert-warning">
Hello world
</div>
<div class="alert alert-danger">
<div class="jenkins-alert jenkins-alert-danger">
Hello world
</div>
<div class="alert alert-success">
<div class="jenkins-alert jenkins-alert-success">
Hello world
</div>