Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm install in order to add to bom #161

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

darinpope
Copy link
Contributor

In trying to add this plugin to bom, I was unable to run:

mvn clean verify

locally to do testing since I did not have npm installed:

[INFO] --- frontend:1.15.0:yarn (yarn mvnbuild) @ customizable-header ---
[INFO] Running 'yarn run mvnbuild' in /Users/dpope/github-forks/customizable-header-plugin
[INFO] yarn run v1.22.19
[INFO] $ npm run build
[INFO] /bin/sh: npm: command not found
[INFO] error Command failed with exit code 127.
[INFO] error Command failed with exit code 127.info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There may be a better way to solve this issue, but this was the simplest way for me.

Once this issue is solved (in whatever way you prefer), I can add this plugin to bom.

Testing done

mvn clean verify succeeds

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

In trying to add this plugin to [bom](https://github.com/jenkinsci/bom), I was unable to run:

`mvn clean verify`

locally to do testing since I did not have `npm` installed:

```
[INFO] --- frontend:1.15.0:yarn (yarn mvnbuild) @ customizable-header ---
[INFO] Running 'yarn run mvnbuild' in /Users/dpope/github-forks/customizable-header-plugin
[INFO] yarn run v1.22.19
[INFO] $ npm run build
[INFO] /bin/sh: npm: command not found
[INFO] error Command failed with exit code 127.
[INFO] error Command failed with exit code 127.info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```

There may be a better way to solve this issue, but this was the simplest way for me.

Once this issue is solved (in whatever way you prefer), I can add this plugin to bom.
@darinpope darinpope requested a review from a team as a code owner November 26, 2024 19:44
@mawinter69 mawinter69 added the developer A pull request that is interesting to developers to have released label Dec 10, 2024
@mawinter69 mawinter69 merged commit 6cbd4e8 into jenkinsci:main Dec 10, 2024
19 checks passed
@darinpope darinpope deleted the add-npm-installation branch December 10, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer A pull request that is interesting to developers to have released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants