-
Notifications
You must be signed in to change notification settings - Fork 742
Update matrix-auth-plugin docs for v3.2+ syntax #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matrix-auth-plugin docs for v3.2+ syntax #2718
Conversation
|
Please review my pull request, and if any problem, please guide me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It looks good, few minor changes that would make this better.
demos/global-matrix-auth/README.md
Outdated
| ## sample-configuration (project based matrix) | ||
| ```yaml | ||
| jenkins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the integration test to use this to prove it works please (and continues to work):
It will need to change to use the JenkinsConfiguredWithReadmeRule
You can then append #<heading-number> to the ConfiguredWithReadme so that it uses the right example, like in:
Line 22 in 4cb0061
| @ConfiguredWithReadme("git-client/README.md#2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a pleasure for me to work on the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you haven't done this
|
Thank you @timja for your thoughtful review and guidance throughout this PR. |
|
Please don't mark comments as resolved until you've pushed the fix |
…/configuration-as-code-plugin into update-matrix-auth-docs
|
I have updated the pr according to the requirement. |
…ixAuthorizationTest.java
integrations/src/test/java/io/jenkins/plugins/casc/ProjectMatrixAuthorizationTest.java
Show resolved
Hide resolved
…jectMatrixAuthorizationTest.java" This reverts commit 9a94154.
Description
Updates the matrix-auth-plugin documentation to reflect the new syntax introduced in matrix-auth plugin version 3.2.
What I Did
entries:format for matrix-auth plugin 3.2+globalMatrixandprojectMatrixconfigurations using the new syntaxChanges Made
entries:with separate user/group configurationsentries:format and grouped permissions by principaldeprecated: warnoption for backward compatibilityReferences
Testing
The documentation updates follow the exact syntax provided in the official matrix-auth 3.2 release notes and maintain backward compatibility information for users migrating from older versions.