Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize plugin #65

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Modernize plugin #65

merged 1 commit into from
Jun 28, 2023

Conversation

basil
Copy link
Member

@basil basil commented May 19, 2023

No description provided.

@basil
Copy link
Member Author

basil commented May 19, 2023

Used my admin powers to replay the build with the Jenkinsfile changes here: https://ci.jenkins.io/job/Plugins/job/conditional-buildstep-plugin/job/PR-65/2/

@basil basil requested a review from a team June 28, 2023 16:05
gounthar
gounthar approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@MarkEWaite MarkEWaite added the chore Maintenance label Jun 28, 2023
@MarkEWaite MarkEWaite merged commit de81901 into jenkinsci:master Jun 28, 2023
@basil basil deleted the refresh branch June 28, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @gounthar @MarkEWaite