Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend against null AbstractFolder.primaryView #447

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 3, 2024

Not observed as such, but seems possible from code inspection. See jenkinsci/jenkins#10023.

@jglick jglick requested a review from a team as a code owner December 3, 2024 23:25
@jglick jglick added the bug label Dec 3, 2024
@jglick jglick requested a review from Vlatombe December 3, 2024 23:26
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, in practice I have seen this issue prior to jenkinsci/hashicorp-vault-plugin#336, caused by earlier mistakes in that plugin, although in that case I think jenkinsci/jenkins#9653 would have prevented the issue.

@jglick jglick merged commit 6edc0fc into jenkinsci:master Dec 4, 2024
17 checks passed
@jglick jglick deleted the primaryView branch December 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants